Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MergeDups] Fix column overflow & flag bug #2104

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented May 2, 2023

Resolves #2097


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this May 2, 2023
@imnasnainaec imnasnainaec changed the title [MergeDups] Fix column overflow [MergeDups] Fix column overflow & flag bug May 2, 2023
@imnasnainaec imnasnainaec marked this pull request as ready for review May 2, 2023 13:51
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +23.08 🎉

Comparison is base (f144c0b) 48.95% compared to head (b27177c) 72.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2104       +/-   ##
===========================================
+ Coverage   48.95%   72.03%   +23.08%     
===========================================
  Files         297       43      -254     
  Lines        9479     3944     -5535     
  Branches      699        0      -699     
===========================================
- Hits         4640     2841     -1799     
+ Misses       4275     1103     -3172     
+ Partials      564        0      -564     
Flag Coverage Δ
backend 72.03% <ø> (ø)
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 254 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) May 2, 2023 14:45
@imnasnainaec imnasnainaec merged commit c8f1cce into master May 2, 2023
@imnasnainaec imnasnainaec deleted the merge-extra branch May 2, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extra word visual issues
3 participants