-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependabot updates for week of 22 May 2023 #2186
Conversation
Bumps [jest-canvas-mock](https://github.com/hustcc/jest-canvas-mock) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/hustcc/jest-canvas-mock/releases) - [Changelog](https://github.com/hustcc/jest-canvas-mock/blob/master/CHANGELOG.md) - [Commits](https://github.com/hustcc/jest-canvas-mock/commits) --- updated-dependencies: - dependency-name: jest-canvas-mock dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@mui/material](https://github.com/mui/material-ui/tree/HEAD/packages/mui-material) from 5.12.3 to 5.13.1. - [Release notes](https://github.com/mui/material-ui/releases) - [Changelog](https://github.com/mui/material-ui/blob/master/CHANGELOG.md) - [Commits](https://github.com/mui/material-ui/commits/v5.13.1/packages/mui-material) --- updated-dependencies: - dependency-name: "@mui/material" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@reduxjs/toolkit](https://github.com/reduxjs/redux-toolkit) from 1.9.3 to 1.9.5. - [Release notes](https://github.com/reduxjs/redux-toolkit/releases) - [Commits](reduxjs/redux-toolkit@v1.9.3...v1.9.5) --- updated-dependencies: - dependency-name: "@reduxjs/toolkit" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.5.0 to 17.6.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.5.0...v17.6.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.3 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@894ff02...eaaf4be) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…v/codecov-action-3.1.4' into dependabot-2023-05-22
…icrosoft.NET.Test.Sdk-17.6.0' into dependabot-2023-05-22
…toolkit-1.9.5' into dependabot-2023-05-22
…rial-5.13.1' into dependabot-2023-05-22
…vas-mock-2.5.1' into dependabot-2023-05-22
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
===========================================
- Coverage 57.45% 41.51% -15.95%
===========================================
Files 241 199 -42
Lines 7716 3811 -3905
Branches 497 497
===========================================
- Hits 4433 1582 -2851
+ Misses 2906 1852 -1054
Partials 377 377
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Bumps [i18next](https://github.com/i18next/i18next) from 22.4.15 to 22.5.0. - [Release notes](https://github.com/i18next/i18next/releases) - [Changelog](https://github.com/i18next/i18next/blob/master/CHANGELOG.md) - [Commits](i18next/i18next@v22.4.15...v22.5.0) --- updated-dependencies: - dependency-name: i18next dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 3 of 8 files at r2, 2 of 3 files at r4, all commit messages.
Reviewable status: 6 of 10 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
.github/workflows/backend.yml
line 26 at r4 (raw file):
allowed-endpoints: > aka.ms:443 api.githug.com:443
This has got to be a typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 8 files at r2, 2 of 2 files at r3.
Reviewable status: 9 of 10 files reviewed, 1 unresolved discussion (waiting on @jmgrady)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 9 of 10 files reviewed, 2 unresolved discussions (waiting on @jmgrady)
.github/workflows/backend.yml
line 28 at r4 (raw file):
api.githug.com:443 api.nuget.org:443 *.codecov.io:443
If *.codecov.io:443
is only covering codecov.io:443
and uploader.codecov.io:443
wouldn't it be better to explicitly list those two?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 20 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @jmgrady)
.github/workflows/backend.yml
line 26 at r4 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
This has got to be a typo.
Done.
.github/workflows/backend.yml
line 28 at r4 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
If
*.codecov.io:443
is only coveringcodecov.io:443
anduploader.codecov.io:443
wouldn't it be better to explicitly list those two?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 15 files at r5, all commit messages.
Reviewable status: 19 of 20 files reviewed, all discussions resolved (waiting on @jmgrady)
.github/workflows/backend.yml
line 31 at r5 (raw file):
api.nuget.org:443 codecov.io:443 uploader.codecov.io:443
Now uploader.codec...
isn't in alphabetical order like the rest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 19 of 20 files reviewed, all discussions resolved (waiting on @jmgrady)
.github/workflows/backend.yml
line 31 at r5 (raw file):
Previously, imnasnainaec (D. Ror.) wrote…
Now
uploader.codec...
isn't in alphabetical order like the rest.
This is not something I have really been working for. If there are multiple endpoints for a top-level domain, I prefer to have them together, e.g.
deb.debian.org:80
github.com:443
mcr.microsoft.com:443
*.data.mcr.microsoft.com:443
api.nuget.org:443
archive.ubuntu.com:80
security.ubuntu.com:80
dc.services.visualstudio.com:443
instead of
*.data.mcr.microsoft.com:443
archive.ubuntu.com:80
api.nuget.org:443
dc.services.visualstudio.com:443
deb.debian.org:80
github.com:443
mcr.microsoft.com:443
security.ubuntu.com:80
(although that first list is not what is actually in backend.yml
).
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 19 of 20 files reviewed, all discussions resolved (waiting on @jmgrady)
.github/workflows/backend.yml
line 31 at r5 (raw file):
Previously, jmgrady (Jim Grady) wrote…
This is not something I have really been working for. If there are multiple endpoints for a top-level domain, I prefer to have them together, e.g.
deb.debian.org:80 github.com:443 mcr.microsoft.com:443 *.data.mcr.microsoft.com:443 api.nuget.org:443 archive.ubuntu.com:80 security.ubuntu.com:80 dc.services.visualstudio.com:443
instead of
*.data.mcr.microsoft.com:443 archive.ubuntu.com:80 api.nuget.org:443 dc.services.visualstudio.com:443 deb.debian.org:80 github.com:443 mcr.microsoft.com:443 security.ubuntu.com:80
(although that first list is not what is actually in
backend.yml
).Thoughts?
That said, it is a lot less work to have VS code sort them for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 16 of 20 files reviewed, all discussions resolved (waiting on @imnasnainaec and @jmgrady)
.github/workflows/backend.yml
line 31 at r5 (raw file):
Previously, jmgrady (Jim Grady) wrote…
That said, it is a lot less work to have VS code sort them for me.
Done. All endpoints should now be in alphabetical order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 15 files at r5.
Reviewable status: 16 of 20 files reviewed, all discussions resolved (waiting on @jmgrady)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
# Conflicts: # .github/workflows/backend.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)
This change is