Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Harvesters from accessing Data Cleanup #2673

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 4, 2023

Resolves "3rd of October, 2023 - Test Observations and Notes" no. 2
Resolves #2676


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend goal labels Oct 4, 2023
@imnasnainaec imnasnainaec self-assigned this Oct 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/components/AppBar/NavigationButtons.tsx 93.33% <100.00%> (+4.44%) ⬆️
src/components/ProjectScreen/ChooseProject.tsx 81.25% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 10, 2023 19:08
@imnasnainaec imnasnainaec merged commit 4b4eca7 into master Oct 10, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the harvester-no-data-cleanup branch October 10, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend goal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access the newly created project; receiving a 403 Forbidden error for the user (Harvester)
3 participants