Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate buttons #2826

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Consolidate buttons #2826

merged 2 commits into from
Dec 7, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 5, 2023

Esp. in preparation for #2795


This change is Reviewable

@imnasnainaec imnasnainaec added frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Dec 5, 2023
@imnasnainaec imnasnainaec self-assigned this Dec 5, 2023
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 21 of 22 files at r1, all commit messages.
Reviewable status: 21 of 22 files reviewed, all discussions resolved (waiting on @imnasnainaec)


src/components/Dialogs/DeleteEditTextDialog.tsx line 100 at r1 (raw file):

          <IconButton
            size="small"
            aria-label="close"

was this intended?

Copy link
Collaborator Author

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 22 of 22 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 4e0e257 into master Dec 7, 2023
17 checks passed
@imnasnainaec imnasnainaec deleted the buttons branch December 7, 2023 16:45
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants