Add audio Speaker #2795
Add audio Speaker #2795
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2795 +/- ##
==========================================
+ Coverage 62.56% 72.49% +9.92%
==========================================
Files 211 262 +51
Lines 4961 9958 +4997
Branches 563 1157 +594
==========================================
+ Hits 3104 7219 +4115
- Misses 1663 2400 +737
- Partials 194 339 +145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Reviewed 2 of 14 files at r1, 7 of 85 files at r3, 6 of 54 files at r4, all commit messages.
Reviewable status: 15 of 102 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)
There was a problem hiding this comment.
Reviewed 3 of 14 files at r1, 3 of 7 files at r2, 33 of 85 files at r3, 48 of 54 files at r4, 4 of 4 files at r5, 1 of 1 files at r6, 2 of 3 files at r7, 1 of 1 files at r8, 1 of 1 files at r9.
Reviewable status: all files reviewed (commit messages unreviewed), 2 unresolved discussions (waiting on @imnasnainaec)
Backend.Tests/Models/SpeakerTests.cs line 18 at r5 (raw file):
var speakerA = new Speaker { Id = Id, ProjectId = ProjectId, Name = Name, Consent = ConsentType.Audio }; Assert.That(speakerA.Equals(speakerA.Clone()), Is.True); }
Not sure if we have done this elsewhere, but it might be worth asserting that ReferenceEquals is false.
src/components/Dialogs/ViewImageDialog.tsx line 30 at r9 (raw file):
<DialogTitle> {props.title} <Icon />
What does an Icon with no attributes or icon name in the text do?
There was a problem hiding this comment.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Github-advanced-security[bot])
Backend.Tests/Models/SpeakerTests.cs line 18 at r5 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
Not sure if we have done this elsewhere, but it might be worth asserting that ReferenceEquals is false.
We haven't done that anywhere. Shall I open an issue to add that to our backend model testing?
src/components/Dialogs/ViewImageDialog.tsx line 30 at r9 (raw file):
Previously, jasonleenaylor (Jason Naylor) wrote…
What does an Icon with no attributes or icon name in the text do?
It's an icon-sized spacer, to prevent the title from being overlapped by the CloseButton, which has absolute positioning into the upper-right corner (or upper-left for rtl).
|
Previously, imnasnainaec (D. Ror.) wrote…
No, it is just a paranoia check. I wouldn't open an issue for it. Any cursory review of a clone method should catch the mistake that this assertion would catch. I think I did add this once to a test suite where someone had made that error but I just checked and can see that we don't do that in our other projects either. Disregard. |
There was a problem hiding this comment.
Reviewed 2 of 2 files at r10.
Reviewable status: all files reviewed (commit messages unreviewed), 1 unresolved discussion (waiting on @Github-advanced-security[bot])
There was a problem hiding this comment.
Dismissed @Github-advanced-security[bot] from a discussion.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
* Add Backend model/repo/controller for speaker * Add audio consent api; Add speaker to project state * Add Speaker types to Startup.cs * Add skeleton setting for project speakers * Enable add/edit/delete speaker * Add consent image upload interface * Enable hearing/seeing speaker consent * Add speaker menu * Consolidate consent icon * Add Pronunciation model for audio * Export audio speaker in pronunciation label * Protect audio with English label to prevent overwriting * Implement FileWithSpeakerId extends File * Enable changing audio speaker * Include consent files in export * Add py script for db update * Remove old one-shot script * Update db script: protect audio; add execute permission
Resolves #719
Resolves #2146
Fixes #2829 by preventing deletion/modification of imported audio.
Will require a database update, as
Word.Audiomoves fromstringtoPronunciation.Use
maintenance/scripts/db_update_audio_type.py.This change is