Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SpeakerController] Fix CreateSpeaker api path #2872

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 9, 2024

Follow-up to #2795

This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working backend labels Jan 9, 2024
@imnasnainaec imnasnainaec self-assigned this Jan 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45caea0) 62.44% compared to head (2076d6b) 62.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2872   +/-   ##
=======================================
  Coverage   62.44%   62.44%           
=======================================
  Files         216      216           
  Lines        5155     5155           
  Branches      593      593           
=======================================
  Hits         3219     3219           
  Misses       1733     1733           
  Partials      203      203           
Flag Coverage Δ
frontend 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 3dfd736 into master Jan 9, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/speaker-create-route branch January 9, 2024 18:24
jmgrady pushed a commit that referenced this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants