Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Speaker] Allow consent audio to be deleted #2873

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 9, 2024

But don't allow speakers to be associated with consent audio (accomplished by the AudioPlayer component with the updateAudioSpeaker prop undefined).

Follow-up to #2795


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Jan 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32c22c7) 72.56% compared to head (60994d8) 83.17%.

❗ Current head 60994d8 differs from pull request most recent head 390a219. Consider uploading reports for the commit 390a219 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2873       +/-   ##
===========================================
+ Coverage   72.56%   83.17%   +10.60%     
===========================================
  Files         262       46      -216     
  Lines        9976     4808     -5168     
  Branches     1163      568      -595     
===========================================
- Hits         7239     3999     -3240     
+ Misses       2398      671     -1727     
+ Partials      339      138      -201     
Flag Coverage Δ
backend 83.17% <ø> (-0.19%) ⬇️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jmgrady jmgrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 7024350 into master Jan 9, 2024
17 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/speaker-consent-audio-delete branch January 9, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants