-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project permissions without having to log out and back in #2952
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2952 +/- ##
==========================================
+ Coverage 74.69% 74.94% +0.24%
==========================================
Files 269 269
Lines 10374 10348 -26
Branches 1229 1226 -3
==========================================
+ Hits 7749 7755 +6
+ Misses 2268 2235 -33
- Partials 357 358 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @imnasnainaec)
Backend.Tests/Services/PermissionServiceTests.cs
line 104 at r1 (raw file):
var user = new User(); var httpContext = CreateHttpContextWithUser(user); var userRole = _userRoleRepo.Create(new UserRole { ProjectId = ProjId, Role = Role.None }).Result;
I feel like Role.None could be handled as a a special case, so I think this test would be better if it used the harvester role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)
Move project permission checking out of JWT token
Fixes #2949
This change is