Unify loading button

[imnasnainaec]

A small bit of #1618

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.82%. Comparing base (301639a) to head (0cabb1c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2962      +/-   ##
==========================================
+ Coverage   72.81%   72.82%   +0.01%     
==========================================
  Files         266      266              
  Lines       10200    10204       +4     
  Branches     1196     1196              
==========================================
+ Hits         7427     7431       +4     
  Misses       2424     2424              
  Partials      349      349              

Flag	Coverage Δ
backend	82.88% <ø> (ø)
frontend	63.43% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmgrady]

Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @imnasnainaec)

---

src/components/Dialogs/CancelConfirmDialog.tsx line 55 at r2 (raw file):

        <Button
          color="primary"
          disabled={loading}

So the user cannot cancel an action once it starts loading? How is one to manage something that is taking too long?

Code quote:

 disabled={loading}

[imnasnainaec]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

src/components/Dialogs/CancelConfirmDialog.tsx line 55 at r2 (raw file):

Previously, jmgrady (Jim Grady) wrote…

So the user cannot cancel an action once it starts loading? How is one to manage something that is taking too long?

Correct. The loading is being used with async functions, usually involving the backend. It is not only to indicate that something is happening, but also to prevent double submissions. We don't have any clean cancel mechanisms is place, so the user's cancel is to refresh the page or navigate to a different page.

[jmgrady]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)