[CharInv] Consolidate find-and-replace pieces

[imnasnainaec]

Follows #2962 (see diff: loading-button...find-and-replace-reorg)
Precedes #2955

---

This change is 

[codecov]

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 72.81%. Comparing base (73dd492) to head (b7de9d3).

Files	Patch %	Lines
...racterInventory/Redux/CharacterInventoryActions.ts	0.00%	10 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
+ Coverage   72.72%   72.81%   +0.08%     
==========================================
  Files         266      264       -2     
  Lines       10209    10201       -8     
  Branches     1196     1196              
==========================================
+ Hits         7425     7428       +3     
+ Misses       2433     2425       -8     
+ Partials      351      348       -3     

Flag	Coverage Δ
backend	82.90% <ø> (+0.20%)	⬆️
frontend	63.39% <9.09%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmgrady]

Reviewed 4 of 15 files at r1, 11 of 11 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @imnasnainaec)

---

src/components/Dialogs/CancelConfirmDialog.tsx line 50 at r2 (raw file):

      <DialogContent>
        <DialogContentText id="alert-dialog-description">
          {props.text || t(props.textId ?? "")}

Previously, it was not possible to have a CancelConfirmDialog with empty text - unless the textId mapped to an empty string.

Unfortunately, textIds are indistinguishable from strings so we can't use the typeof operator.

If the interface is changed to:

interface CancelConfirmDialogProps {
  open: boolean;
  text: string | ReactElement;
  isLocalized?: boolean;
  handleCancel: () => void;
  handleConfirm: () => Promise<void> | void;
  buttonIdCancel?: string;
  buttonIdConfirm?: string;
}

then when isLocalized is false or undefined, it is a TextId. Making it optional means you only have to specify it in the one instance where a ReactElement is provided.

Code quote:

{props.text || t(props.textId ?? "")}

---

src/goals/CharacterInventory/Redux/CharacterInventoryActions.ts line 179 at r2 (raw file):

      "g"
    );
    for (const word of changedWords) {

Add a comment explaining what is going on here - that you're escaping special characters in the find string (and that a regular expression is required to replace all occurrences in the string).
(or something to that effect)

Suggestion:

    const findRegExp = new RegExp(
      findValue.replace(/[-\\^$*+?.()|[\]{}]/g, "\\$&"),
      "g"
    );

[imnasnainaec]

Reviewable status: 13 of 20 files reviewed, 2 unresolved discussions (waiting on @imnasnainaec and @jmgrady)

---

src/components/Dialogs/CancelConfirmDialog.tsx line 50 at r2 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Previously, it was not possible to have a CancelConfirmDialog with empty text - unless the textId mapped to an empty string.

Unfortunately, textIds are indistinguishable from strings so we can't use the typeof operator.

If the interface is changed to:

interface CancelConfirmDialogProps {
  open: boolean;
  text: string | ReactElement;
  isLocalized?: boolean;
  handleCancel: () => void;
  handleConfirm: () => Promise<void> | void;
  buttonIdCancel?: string;
  buttonIdConfirm?: string;
}

then when isLocalized is false or undefined, it is a TextId. Making it optional means you only have to specify it in the one instance where a ReactElement is provided.

Done.

---

src/goals/CharacterInventory/Redux/CharacterInventoryActions.ts line 179 at r2 (raw file):

Previously, jmgrady (Jim Grady) wrote…

Add a comment explaining what is going on here - that you're escaping special characters in the find string (and that a regular expression is required to replace all occurrences in the string).
(or something to that effect)

Done.

[jmgrady]

Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)