Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GlossWithSuggestions] Use ... for all but last word #3226

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 3, 2024

Resolves #3189

Screenshot 2024-07-03 150029 Screenshot 2024-07-03 150055 Screenshot 2024-07-03 150140 Screenshot 2024-07-03 150155


This change is Reviewable

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (b06fac6) to head (2022e48).
Report is 41 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3226      +/-   ##
==========================================
- Coverage   74.82%   74.74%   -0.08%     
==========================================
  Files         277      277              
  Lines       10637    10641       +4     
  Branches     1278     1279       +1     
==========================================
- Hits         7959     7954       -5     
- Misses       2314     2321       +7     
- Partials      364      366       +2     
Flag Coverage Δ
backend 83.84% <ø> (-0.19%) ⬇️
frontend 66.71% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec requested review from jmgrady and andracc and removed request for jmgrady July 9, 2024 15:42
@imnasnainaec imnasnainaec marked this pull request as draft July 12, 2024 14:51
@imnasnainaec imnasnainaec marked this pull request as ready for review July 12, 2024 15:29
@imnasnainaec imnasnainaec marked this pull request as draft July 12, 2024 15:42
@imnasnainaec imnasnainaec marked this pull request as ready for review July 12, 2024 17:19
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 8975e57 into master Jul 15, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the data-entry-multiword-gloss branch July 15, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Re-evaluate gloss suggestions for multi-word glosses
2 participants