Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear duplicate selection when user returns to vernacular input #3290

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 1, 2024

Fixes #3259 (both gives the expected behavior and fixes the odd bug)


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 1, 2024
@imnasnainaec imnasnainaec changed the title Clear vern selection when user returns to vern text field Clear duplicate selection when user returns to vernacular input Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.62%. Comparing base (468e516) to head (6a27c3e).
Report is 31 commits behind head on master.

Files with missing lines Patch % Lines
...onents/DataEntry/DataEntryTable/NewEntry/index.tsx 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3290      +/-   ##
==========================================
+ Coverage   74.59%   74.62%   +0.02%     
==========================================
  Files         279      279              
  Lines       10683    10686       +3     
  Branches     1289     1290       +1     
==========================================
+ Hits         7969     7974       +5     
+ Misses       2353     2351       -2     
  Partials      361      361              
Flag Coverage Δ
backend 83.97% <ø> (+0.08%) ⬆️
frontend 66.41% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 474ec40 into master Aug 5, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the new-entry-focus branch August 5, 2024 17:23
imnasnainaec added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Odd focus issue between dialogs, vernacular, and gloss
2 participants