Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataEntryTable] Fix NewEntry vernacular focus issues #3297

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 6, 2024

Fixes #3258
Makes a simplification to decrease fragility and increase managability: When enter is pressed from the vernacular field, always shift focus to the gloss field.
Fixes bug introduced in #3290 by using the Dialog prop disableRestoreFocus
Fixes prop-with-key-spread console warning by explicitly specifying the LiWithFont's key
Remove unnecessary Autocomplete props in GlossWithSuggestions and VernWithSuggestions


This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. component: DataEntry labels Aug 6, 2024
@imnasnainaec imnasnainaec self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.58%. Comparing base (fea400d) to head (8b3c7d5).
Report is 37 commits behind head on master.

Files with missing lines Patch % Lines
...yTable/EntryCellComponents/VernWithSuggestions.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
- Coverage   74.60%   74.58%   -0.02%     
==========================================
  Files         279      279              
  Lines       10686    10680       -6     
  Branches     1290     1287       -3     
==========================================
- Hits         7972     7966       -6     
+ Misses       2353     2352       -1     
- Partials      361      362       +1     
Flag Coverage Δ
backend 83.87% <ø> (-0.07%) ⬇️
frontend 66.43% <71.42%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review August 7, 2024 15:27
@imnasnainaec imnasnainaec mentioned this pull request Aug 7, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't build and test with this, so I'm giving an :lgtm: on trust that you have. The code moved in the more simple direction, so I like the change.

Reviewed 2 of 4 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jmgrady)

@imnasnainaec imnasnainaec merged commit 92050a5 into master Aug 8, 2024
19 checks passed
@imnasnainaec imnasnainaec deleted the new-entry-focus branch August 8, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: DataEntry frontend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Bad ENTER behavior when switching from one existing vernacular to another
2 participants