Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New entry vern #3294

Closed
wants to merge 3 commits into from
Closed

New entry vern #3294

wants to merge 3 commits into from

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Aug 5, 2024

Fixes #3258


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Aug 5, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.60%. Comparing base (474ec40) to head (44fd6d6).

Files Patch % Lines
...yTable/EntryCellComponents/VernWithSuggestions.tsx 0.00% 3 Missing ⚠️
...Table/EntryCellComponents/GlossWithSuggestions.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3294      +/-   ##
==========================================
- Coverage   83.87%   74.60%   -9.28%     
==========================================
  Files          47      279     +232     
  Lines        4993    10683    +5690     
  Branches      600     1288     +688     
==========================================
+ Hits         4188     7970    +3782     
- Misses        660     2352    +1692     
- Partials      145      361     +216     
Flag Coverage Δ
backend 83.89% <ø> (+0.02%) ⬆️
frontend 66.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec
Copy link
Collaborator Author

Replaced by #3297

@imnasnainaec imnasnainaec deleted the new-entry-vern branch August 7, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataEntry] Bad ENTER behavior when switching from one existing vernacular to another
1 participant