Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow lift import after an audio file has been added to the project #790

Closed
wants to merge 5 commits into from

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Oct 30, 2020

Closes #788


This change is Reviewable

@johnthagen johnthagen added bug Something isn't working backend import/export labels Oct 30, 2020
@johnthagen johnthagen self-assigned this Oct 30, 2020
@codecov-io
Copy link

codecov-io commented Oct 30, 2020

Codecov Report

Merging #790 (5dd0cc2) into master (04279da) will decrease coverage by 3.90%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
- Coverage   51.17%   47.26%   -3.91%     
==========================================
  Files         237      200      -37     
  Lines        6449     3290    -3159     
  Branches      416      416              
==========================================
- Hits         3300     1555    -1745     
+ Misses       2841     1427    -1414     
  Partials      308      308              
Flag Coverage Δ
backend ?
frontend 47.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/WordController.cs
Backend/Controllers/ProjectController.cs
Backend/Contexts/EmailContext.cs
Backend/Contexts/UserEditContext.cs
Backend/Contexts/UserRoleContext.cs
Backend/Services/SemDomParser.cs
Backend/Models/Word.cs
Backend/Services/UserRoleApiServices.cs
Backend/Controllers/UserController.cs
Backend/Services/PermissionService.cs
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04279da...5dd0cc2. Read the comment docs.

@johnthagen
Copy link
Collaborator Author

This still fails on the line:

Directory.Move(extractedDirPath, correctPath);

As it's clear this never worked, probably should talk to @jasonleenaylor about if this is actually an intended supported feature before continuing to go down this path.

@johnthagen
Copy link
Collaborator Author

Closing in favor of #810

@johnthagen johnthagen closed this Nov 13, 2020
@johnthagen johnthagen deleted the fix-lift-import-after-audio branch November 13, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working import/export
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import Lift File if project already contains an entry with an audio file
2 participants