-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor temporary files generated by backend #810
Conversation
Codecov Report
@@ Coverage Diff @@
## master #810 +/- ##
==========================================
+ Coverage 51.03% 51.26% +0.23%
==========================================
Files 239 239
Lines 6480 6505 +25
Branches 420 420
==========================================
+ Hits 3307 3335 +28
+ Misses 2863 2860 -3
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 6 files at r3, 2 of 3 files at r4.
Reviewable status: 4 of 9 files reviewed, all discussions resolved (waiting on @imnasnainaec)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r4, 4 of 4 files at r5.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)
Holding off merging this into |
First steps on #789
Closes #788
Follow on to #791
/tmp
instead of.CombineFiles
Database migration steps:
.CombineFiles
for project folders that containImport/*.zip
{"liftImported": true}
for that Project ID in the databaseThis change is