Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor temporary files generated by backend #810

Merged
merged 15 commits into from
Nov 17, 2020

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Nov 13, 2020

First steps on #789

Closes #788

Follow on to #791

Database migration steps:

  1. Search .CombineFiles for project folders that contain Import/*.zip
    • For each project, set {"liftImported": true} for that Project ID in the database

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #810 (100d5d9) into master (4bfc0ed) will increase coverage by 0.23%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   51.03%   51.26%   +0.23%     
==========================================
  Files         239      239              
  Lines        6480     6505      +25     
  Branches      420      420              
==========================================
+ Hits         3307     3335      +28     
+ Misses       2863     2860       -3     
  Partials      310      310              
Flag Coverage Δ
backend 55.68% <91.66%> (+0.45%) ⬆️
frontend 47.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Backend/Controllers/AudioController.cs 54.23% <ø> (ø)
Backend/Services/LiftApiServices.cs 94.60% <ø> (ø)
Backend/Services/ProjectApiServices.cs 0.00% <0.00%> (ø)
src/types/project.tsx 100.00% <ø> (ø)
Backend/Models/Project.cs 72.38% <80.00%> (+0.16%) ⬆️
Backend/Controllers/LiftController.cs 57.50% <94.44%> (-0.52%) ⬇️
Backend/Helper/FileUtilities.cs 78.08% <100.00%> (+15.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bfc0ed...100d5d9. Read the comment docs.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 6 files at r3, 2 of 3 files at r4.
Reviewable status: 4 of 9 files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r4, 4 of 4 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@imnasnainaec
Copy link
Collaborator

Holding off merging this into master until #815 is also ready to use.

@imnasnainaec imnasnainaec merged commit d7cf58f into master Nov 17, 2020
@imnasnainaec imnasnainaec deleted the refactor-backend-file-paths branch November 17, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import Lift File if project already contains an entry with an audio file
4 participants