Remove temporary .zip files generated during Lift import and export

[johnthagen]

Closes #786

Should help some with #656

• The fix for LIFT export fixes a true disk space leak.
• Since Lift import can only be performed once, there is no recurring leak fixed on the import side, but the temporary file is still removed

The following files will no longer persist after an import in .CombineFiles/<ProjectID>/Import:

• <temp-name-with-date>.zip

Or after an export in .CombineFiles/<ProjectID>/Export:

• <temp-name>.zip
• LiftExport

---

This change is 

[imnasnainaec]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @imnasnainaec and @johnthagen)

---

Backend/Services/LiftApiServices.cs, line 271 at r1 (raw file):

Quoted 7 lines of code…

            // Compress everything
            var destinationFileName = Path.Combine(exportDir,
                Path.Combine($"LiftExportCompressed-{proj.Id}_{DateTime.Now:yyyy-MM-dd_hh-mm-ss}.zip"));
            ZipFile.CreateFromDirectory(Path.GetDirectoryName(zipDir), destinationFileName);

            // Clean up the temporary folder structure that was compressed.
            Directory.Delete(Path.Combine(exportDir, "LiftExport"), true);

It looks like the zip file is created into exportDir, which is then immediately deleted. Shouldn't zipDir be deleted instead?

[imnasnainaec]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @imnasnainaec)

---

Backend/Services/LiftApiServices.cs, line 271 at r1 (raw file):

Previously, imnasnainaec (D. Ror.) wrote…

            // Compress everything
            var destinationFileName = Path.Combine(exportDir,
                Path.Combine($"LiftExportCompressed-{proj.Id}_{DateTime.Now:yyyy-MM-dd_hh-mm-ss}.zip"));
            ZipFile.CreateFromDirectory(Path.GetDirectoryName(zipDir), destinationFileName);

            // Clean up the temporary folder structure that was compressed.
            Directory.Delete(Path.Combine(exportDir, "LiftExport"), true);

It looks like the zip file is created into exportDir, which is then immediately deleted. Shouldn't zipDir be deleted instead?

Sorry, never mind, I see that it's a subfolder of exportDir (which contains zipDir) that is being deleted.

[imnasnainaec]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, all discussions resolved (waiting on @johnthagen)

Erroneous change request

[codecov-io]

Codecov Report

Merging #791 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   51.21%   51.23%   +0.02%     
==========================================
  Files         237      237              
  Lines        6428     6431       +3     
  Branches      410      410              
==========================================
+ Hits         3292     3295       +3     
  Misses       2833     2833              
  Partials      303      303              

Flag	Coverage Δ
backend	55.22% <100.00%> (+0.04%)	⬆️
frontend	47.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
Backend/Controllers/LiftController.cs	58.01% <100.00%> (+0.65%)	⬆️
Backend/Services/LiftApiServices.cs	94.60% <100.00%> (+0.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54c5409...3364b35. Read the comment docs.

[jasonleenaylor]

Reviewed 1 of 3 files at r3, 2 of 2 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)