Move Machine engine to Serval repo #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- align all Scripture corpora to Original versification
Fix CI * parenthesis for order of operations || && * master, not main
* default to major biblical terms - #357 Update tests - target-1 does not include BiblicalTermsListSetting to invoke default. * fix
- add new ScriptureRef corpus ref class - update Scripture corpora classes to use ScriptureRef - add ScriptureRefUsfmParserHandlerBase class to track ScriptureRef in USFM - update UsfmTextUpdater and UsfmTextBase to use ScriptureRefUsfmParserHandlerBase - add support for updating non-Scripture paragraphs and notes - update NmtPreprocessBuildJob to support non-Scripture segments Co-authored-by: John Lambert <john_lambert@sil.org>
* run test coverage locally * More coverage of ScriptureRef and ScriptureElement. * Reviewer Comments * Updates from reviewer comments
* Convert to MongoDB callback API #314 * Update to newest data access layer
* Control the pretranslation of existing text: #370 * Fix tests
* Serval was down until langtags.json was added back. Add test to force download. * Reviwer comments
* SMT on ClearML * Replace CPU, GPU types with just Hangfire vs ClearML as well as engine type * Allow each engine type to have it's own queue and docker image * SMT build defaults on ClearML * NMT local train removed * Download and upload model in factory using tar.gz and the build directory * Preserve changes from sillsdev/machine#205. This reverts commit cf5f45393b4e86b2813ca1beb2c915d88539d159. --------- Co-authored-by: Damien Daspit <damien_daspit@sil.org>
* retry hangfire jobs - sillsdev/machine#158 * Fixed auto-retry as per this forum post: https://discuss.hangfire.io/t/recurring-jobs-do-not-automatically-get-retried-after-application-crash-net-core-service/9160 * MongoDB can't handle documents greater than 16MB * Treat messages from one id as a group * Kill failing messages over 4 days old * Make outbox truly generic, handling multiple queues * Ensure globally ordered outbox messages * Add "MoveAsync" to SharedStorage * Refactor saving pretranslations file * correctly handle scoped services in background services * abstract file handling of content in outbox services * merge Id and Context in Outbox model * Consistently use strings for outbox message method identifiers * split up tests into true unit tests --------- Co-authored-by: Damien Daspit <damien_daspit@sil.org>
|
|
johnml1135
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Reviewed 200 of 200 files at r1, 2 of 2 files at r2, 3 of 3 files at r5, 1 of 1 files at r7, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
johnml1135
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is