Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move Machine engine to Serval repo (#421)" #425

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Jul 9, 2024

This reverts commit e62da1f.


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.18%. Comparing base (e62da1f) to head (45bf182).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
+ Coverage   61.73%   71.18%   +9.45%     
==========================================
  Files         232      151      -81     
  Lines       11825     7195    -4630     
  Branches     1510     1129     -381     
==========================================
- Hits         7300     5122    -2178     
+ Misses       3998     1615    -2383     
+ Partials      527      458      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 201 of 201 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit d5cc6ed into main Jul 9, 2024
2 checks passed
@ddaspit ddaspit deleted the revert-421-machine branch July 9, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants