Tweak workflows with respect to playwright tests #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megahirt
force-pushed
the
chore/workflowTweaks
branch
from
ea912da
to
21cd12e
Compare
longrunningprocess
suggested changes
Mar 25, 2022
longrunningprocess
approved these changes
Mar 28, 2022
change the name of the PHP extension per VSCode extension name change in the marketplace (error in VSCode)
- moved to using a compound run statement in both yml files - had to shift around the working directory a bit
megahirt
force-pushed
the
chore/workflowTweaks
branch
from
562455b
to
20e60a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks the
pull-requestandintegrate-and-deployworkflows.Tweaks in this PR:
--with-depsfromnpx playwright installbecause it's appears unnecessary and is slowernpm cisince we're on CI - it seems to be the recommended thing to doA future TODO could be to restructure the integrate and deploy such that it is generic enough to be used in the PR workflow. These two workflows are increasingly performing the same function.
Note: The changes to integrate-and-deploy won't actually be tested until this PR is merged. If there's a problem with my change I'll either follow up with another PR or make a change directly on develop.
Checklist