Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lfmerge from LF app container #1389

Merged
merged 2 commits into from
Apr 25, 2022

Conversation

rmunn
Copy link
Collaborator

@rmunn rmunn commented Apr 23, 2022

Description

Now that lfmerge is running in a separate container, we can remove the lfmerge package (and all its dependencies) from the LF app container, reducing the size of the app container.

This is a continuation of #1315.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • New feature (non-breaking change which adds functionality)

Testing on your branch

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Load Language Forge and create a new project from Language Depot
  • Edit the project in Language Forge (add an entry, modify a couple of entries) and do another Send/Receive
  • Send/Receive that same project in FieldWorks to ensure that the changes really did come through

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

  • Reviewer1 (YYYY-MM-DD HH:MM)
  • Reviewer2 (YYYY-MM-DD HH:MM)

@rmunn rmunn self-assigned this Apr 23, 2022
@github-actions
Copy link

Unit Test Results

    1 files      1 suites   11s ⏱️
373 tests 373 ✔️ 0 💤 0

Results for commit df39e19.

Copy link
Contributor

@longrunningprocess longrunningprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like excellent work! I've just looked over the code and not pulled it local to test but I trust you have.

@rmunn rmunn merged commit a5b7b4f into develop Apr 25, 2022
@rmunn rmunn deleted the chore/remove-lfmerge-from-lf-container branch April 25, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants