Move lfmerge container to separate pod using pod affinity #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two env values in the lfmerge container were being read as an int and a boolean, when Kubernetes requires them all to be strings. So we quote them to ensure they will be strings.
Move lfmerge container to separate pod, using pod affinity to force it to always run on the same node as the app container so that they can share the sendreceive volume.
The lfmerge container doesn't need any files from the languageforge repo at all, so let's make its Docker build context as small as possible. That way it's a nearly-instant build once the image has downloaded.
longrunningprocess
approved these changes
May 23, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a follow-up to #1389, this PR moves the lfmerge container into a separate pod, using pod affinity to ensure that it will be assigned to the same node as the main app. (Since they share a persistent volume, this is necessary so that the volume can be mounted in ReadWriteOnce mode instead of ReadWriteMany — ReadWriteMany greatly limits the number of storage backends available, while ReadWriteOnce is a lot easier for storage backends to use. (I see https://longhorn.io/blog/longhorn-v1.1.0/ from January 2021 that announces ReadWriteMany availability in Longhorn, so perhaps the pod affinity can be gotten rid of at some point).
Fixes #1406.
Type of Change
Only keep lines below that describe this change, then delete the rest.
Screenshots
Please provide screenshots / animations for any change that involves the UI. Please provide animations to demonstrate user interaction / behavior changes
Testing on your branch
Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.
makeThis PR makes basically no changes to the docker-compose build (one very minor change), so I don't expect it to have any effect. Most of the testing will need to be on the QA server.
Checklist
qa.languageforge.org testing
Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org