Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor parseISO() to Date() in filters to fix sync date string disp… #1423

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

palmtreefrb
Copy link
Contributor

@palmtreefrb palmtreefrb commented Jun 9, 2022

Description

The date/time display on a project's send/receive page was not displaying properly.

Fixes # (issue)
Changed parseISO() to Date() to enable formatDistance method to work correctly.

Type of Change

Only keep lines below that describe this change, then delete the rest.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Screenshot from 2022-06-09 06-01-03

Testing on your branch

Please describe how to test and/or verify your changes. Provide instructions so we can reproduce. Please also provide relevant test data as necessary. These instructions will be used for QA testing below.

  • Navigate to Settings, Synchronize. Last sync date string should display

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have added tests that prove my fix is effective or that my feature works

qa.languageforge.org testing

Reviewers: add/replace your name below and check the box to sign-off/attest the feature works as expected on qa.languageforge.org

image

  • Reviewer2 (YYYY-MM-DD HH:MM)

@github-actions
Copy link

github-actions bot commented Jun 9, 2022

Unit Test Results

373 tests   373 ✔️  9s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit cd00d72.

@palmtreefrb palmtreefrb marked this pull request as ready for review June 9, 2022 13:17
Copy link
Collaborator

@megahirt megahirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Rick.

@palmtreefrb palmtreefrb merged commit 3733255 into develop Jun 14, 2022
@palmtreefrb palmtreefrb deleted the feature/time-string-missing-from-sync-dialog branch June 14, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: relative time string missing from sync dialog Last synced date missing
3 participants