-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local and GitHub playwright testing improvements #1472
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wright params E.g. npm run make playwright-tests params="--headed"
- Save/Upload test results - Save screenshots (these seems to be included in traces, so they may not add value) - Show list of tests as they're executed (if uncaught exceptions are thrown in async functions in tests, this may make it easier to figure out where)
myieye
force-pushed
the
chore/testing-improvements
branch
from
September 20, 2022 14:02
ebc42d4
to
ee6687a
Compare
JeanneSon
reviewed
Sep 21, 2022
JeanneSon
reviewed
Sep 21, 2022
megahirt
approved these changes
Sep 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great additions, thanks @myieye !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various minor playwright improvements:
make playwright-tests params="--headed"
npm run make playwright-tests params="--headed"
globalSetup.ts
and add ts-lint rule to watch for cases like thisglobalSetup.ts
, because: (1) it's documented as best practice, (2) it doesn't break anything and (3) it eliminates a potential culprit of "socket hang up" mentioned in bug: Race condition in Playwright webServer config #1402Type of Change
Screenshots
Checklist