Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local and GitHub playwright testing improvements #1472

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Local and GitHub playwright testing improvements #1472

merged 4 commits into from
Sep 22, 2022

Commits on Sep 20, 2022

  1. Allow running make commands from any folder wtih npm and passing play… 

    …wright params

E.g. npm run make playwright-tests params="--headed"
    @myieye
    myieye committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    f0bfd84 View commit details
    Browse the repository at this point in the history

  2. Improve E2E test debugging on GitHub 

    - Save/Upload test results
- Save screenshots (these seems to be included in traces, so they may not add value)
- Show list of tests as they're executed (if uncaught exceptions are thrown in async functions in tests, this may make it easier to figure out where)
    @myieye
    myieye committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    60630c8 View commit details
    Browse the repository at this point in the history

  3. Cache playwright browsers in GitHub

    @myieye
    myieye committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    49d69c1 View commit details
    Browse the repository at this point in the history

  4. Fix dangling promise and open browser contexts

    @myieye
    myieye committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    ee6687a View commit details
    Browse the repository at this point in the history