-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Makefile and docker-compose.yml to repo root #1531
Move Makefile and docker-compose.yml to repo root #1531
Conversation
c288c21
to
2b6494a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, this is great work with surgical precision! LGTM
I assume that you have run all of the Makefile targets locally and it behaves as expected, since CI does not exercise all targets.
2b6494a
to
4848e99
Compare
Yeah, I ran all the make targets in the main makefile.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent work so far, I think there are a handful of improvements we can still make
Fixes #1511
Description
Makefiles as well as docker-compose.yml are expected to be in the project root, so this PR moves them both there.
Type of Change
Checklist