Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify docker-compose.yml and it's usage #1535

Conversation

myieye
Copy link
Collaborator

@myieye myieye commented Oct 18, 2022

Fixes #1511

Description

This is the implementation of @longrunningprocess's suggestions on my first PR.

@github-actions
Copy link

github-actions bot commented Oct 18, 2022

Unit Test Results

368 tests   368 ✔️  11s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 3328f1d.

♻️ This comment has been updated with latest results.

docs/DEVELOPER.md Show resolved Hide resolved
@longrunningprocess longrunningprocess enabled auto-merge (squash) October 18, 2022 15:38
@myieye
Copy link
Collaborator Author

myieye commented Oct 19, 2022

@longrunningprocess I'd appreciate your thoughts on the failed check: https://github.com/sillsdev/web-languageforge/actions/runs/3274632139/jobs/5388810027

I assumed it's, because docker-compose (which is used by the workflow) doesn't accept quite the same syntax as docker compose? (as it seems unhappy about the missing context: ..)

@myieye myieye force-pushed the chore/1511-chore-move-makefile-to-repo-root-out-of-docker-directory branch from c410656 to 42ba78e Compare October 19, 2022 13:04
@myieye myieye force-pushed the chore/1511-chore-move-makefile-to-repo-root-out-of-docker-directory branch from 7f802dc to 3328f1d Compare October 19, 2022 14:17
@longrunningprocess longrunningprocess merged commit 69b1e1a into develop Oct 19, 2022
@longrunningprocess longrunningprocess deleted the chore/1511-chore-move-makefile-to-repo-root-out-of-docker-directory branch October 19, 2022 14:28
@myieye myieye mentioned this pull request Oct 20, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: move Makefile to repo root, out of docker directory
2 participants