Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert project links to avoid dashboard #1544

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

megahirt
Copy link
Collaborator

@megahirt megahirt commented Oct 19, 2022

Fixes #1540
Workaround for #1536

This PR is directly against the master branch, intended to be shipped quickly. Unfortunately, develop branch would not build for me on mac (see Slack channel for details).

Description

Based upon my workshop this morning and observing multiple projects experiencing 500 errors in the dashboard, some consistently, this commit reverts the project page links to go directly to the lexicon app, instead of the dashboard.

This can be reverted back to the dashboard once we have more confidence that dashboard is stable and does not block users from getting to the app.

Type of Change

  • Temporary (emergency) workaround for blocked users, intended to be reverted at a later date

Screenshots

image

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

. The (dashboard) link goes to the dashboard. In this way users are not blocked for projects that are currently experiencing 500 errors.

  • The project page should contain multiple links per project
  • The main link goes directly to the lexicon app
  • The (dashboard) link goes to the dashboard for that project
  • There is a grey project code also visible in the project row
  • The "My Projects" list in the lexicon app contains links that go directly to the lexical app and avoids the dashboard

qa.languageforge.org testing

Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org

  • Tester1 (YYYY-MM-DD HH:MM)
  • Tester2 (YYYY-MM-DD HH:MM)

Based upon my workshop this morning and observing multiple projects experiencing 500 errors in the dashboard, some consistently, this commit reverts the project page links to go directly to the lexicon app, instead of the dashboard.

This can be reverted back to the dashboard once we have more confidence that dashboard is stable and does not block users from getting to the app.
@github-actions
Copy link

Unit Test Results

368 tests   368 ✔️  12s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 8f99772.

Copy link
Collaborator

@laineyhm laineyhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Watched Chris demo the change earlier today.

@megahirt
Copy link
Collaborator Author

The playwright tests are failing due to the project page locator not correctly finding the project link (whose structure has changed). Probably has to do with this function https://github.com/sillsdev/web-languageforge/blob/bugfix/dashboardlink/test/e2e/pages/projects.page.ts#L138

This will be fixed/addressed in a PR against develop. For now, this PR is an emergency patch to unblock users.

@megahirt megahirt merged commit 4165a7f into master Oct 19, 2022
@megahirt megahirt deleted the bugfix/dashboardlink branch October 19, 2022 11:19
@megahirt megahirt restored the bugfix/dashboardlink branch October 19, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants