Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily revert project list links to avoid dashboard 500 errors and unblock users #1545

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

megahirt
Copy link
Collaborator

This PR duplicates the hotfix to master PR #1544 , but this time as a proper PR against develop.

In this PR I need to fix up the playwright tests to suit after changing the project board links, since playwright tests are failing with this change.

The description below is a copy of the PR #1544 description and details.

Fixes #1540
Workaround for #1536

This PR is directly against the master branch, intended to be shipped quickly. Unfortunately, develop branch would not build for me on mac (see Slack channel for details).

Description

Based upon my workshop this morning and observing multiple projects experiencing 500 errors in the dashboard, some consistently, this commit reverts the project page links to go directly to the lexicon app, instead of the dashboard.

This can be reverted back to the dashboard once we have more confidence that dashboard is stable and does not block users from getting to the app.

Type of Change

  • Temporary (emergency) workaround for blocked users, intended to be reverted at a later date

Screenshots

image

Checklist

  • I have performed a self-review of my own code
  • I have reviewed the title/description of this PR which will be used as the squashed PR commit message
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

How to test

. The (dashboard) link goes to the dashboard. In this way users are not blocked for projects that are currently experiencing 500 errors.

  • The project page should contain multiple links per project
  • The main link goes directly to the lexicon app
  • The (dashboard) link goes to the dashboard for that project
  • There is a grey project code also visible in the project row
  • The "My Projects" list in the lexicon app contains links that go directly to the lexical app and avoids the dashboard

qa.languageforge.org testing

Testers: Check the box and put in a date/time to sign-off/attest the feature works as expected on qa.languageforge.org

  • Tester1 (YYYY-MM-DD HH:MM)
  • Tester2 (YYYY-MM-DD HH:MM)

@github-actions
Copy link

github-actions bot commented Oct 19, 2022

Unit Test Results

368 tests   368 ✔️  8s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit 4484749.

♻️ This comment has been updated with latest results.

@megahirt
Copy link
Collaborator Author

@myieye I am expecting the playwright tests to fail for this PR, see comment: #1544 (comment)

I'm heading to bed shortly, I was wondering if you could fix this up?

@myieye
Copy link
Collaborator

myieye commented Oct 19, 2022

@myieye I am expecting the playwright tests to fail for this PR, see comment: #1544 (comment)

I'm heading to bed shortly, I was wondering if you could fix this up?

I'm working on it. The failure was not was I was expecting, so I was bashing my head against the wall for a while, but I see the problem now. 😆 I'll continue tomorrow.

Based upon my workshop this morning and observing multiple projects experiencing 500 errors in the dashboard, some consistently, this commit reverts the project page links to go directly to the lexicon app, instead of the dashboard.

This can be reverted back to the dashboard once we have more confidence that dashboard is stable and does not block users from getting to the app.
@myieye myieye force-pushed the bugfix/dashboardlink branch 3 times, most recently from 0ba208b to 89a8dcb Compare October 20, 2022 13:20
Copy link
Contributor

@longrunningprocess longrunningprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sillsdev/web-languageforge/pull/1545/files#diff-44f55c24acb4701409c1e1b3e494088c5b54e043c3f905299307b5419ebf47f5R49 threw me a little, either that project class was added for the tests as a locator or there was already a class by that name?

@longrunningprocess longrunningprocess merged commit f8ca6ce into develop Oct 20, 2022
@longrunningprocess longrunningprocess deleted the bugfix/dashboardlink branch October 20, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Show the project code next to the project search result
3 participants