fix: git-repos test inconsistent #972
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
gitphill
force-pushed
the
fix/git-repos-test
branch
6 times, most recently
from
34a0898
to
132aae0
Compare
lili2311
changed the title
dkontorovskyy
force-pushed
the
fix/git-repos-test
branch
from
132aae0
to
bbb616d
Compare
aviadhahami
approved these changes
Mar 19, 2020
The git-repos test on Windows, Node 8 failing with connection timeouts. Trying for loop instead of forEach inside try/catch and asserting response from test is truthy in an attempt to make test more consistent in this environment.
gitphill
force-pushed
the
fix/git-repos-test
branch
from
bbb616d
to
6005b60
Compare
|
Closing as it's been a year and we'll be migrating the test to Jest anyway. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removing t.end since test is async in an attempt to
have the test run more consistantly.
Any background context you want to provide?
Appveyor test inconsistant failures for this test.
What are the relevant tickets?
Screenshots
Additional questions