Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: git-repos test inconsistent #972

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions test/git-repos.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import * as cli from '../src/cli/commands/';
import * as tap from 'tap';
import { test } from 'tap';

const urls = [
// a repo with no dependencies so it will never be vulnerable (2017-05-15)
Expand All @@ -9,15 +9,13 @@ const urls = [
'Snyk/vulndb-fixtures.git',
];

urls.forEach((url) => {
// TODO: investigate why this test fails on Windows, Node 8
tap.skip('snyk.test supports ' + url + ' structure', async (t) => {
try {
await cli.test(url);
t.pass('url worked');
} catch (err) {
t.threw(err);
t.end();
test('snyk test supports different URLs', async (t) => {
try {
for (const url of urls) {
const res = await cli.test(url);
t.ok(res, `snyk test ${url} ok`);
}
});
} catch (err) {
t.fail('unexpected error thrown: ' + err.message);
}
});