Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: upgrade envoyproxy/go-control-plane #10049

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

sam-heilbron
Copy link
Contributor

@sam-heilbron sam-heilbron commented Sep 16, 2024

Description

Remove a pin on the go-control-plane-fork-v2 repo, and update the go-control-plane dependency

Context

We agreed in Slack that the pin was unnecessary.
Previously this pin was included as part of our ext-proc backports and was no longer needed in envoy 1.30 as thats where the upstream changes merged. We updated our enterprise to no longer rely on this api fork and now are correctly backporting that to oss.

This would have been included in #10026, which is already a large PR, so I split it off into something that is more easily reviewable.

Interesting decisions

Testing steps

  • Confirm that CI passes

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Sep 16, 2024
@sam-heilbron sam-heilbron removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Sep 16, 2024
Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit b6b8870):

https://gloo-edge--pr10049-sh-upgrade-go-contro-bikedqi5.web.app

(expires Mon, 23 Sep 2024 21:57:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@soloio-bulldozer soloio-bulldozer bot merged commit bddae6d into main Sep 16, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/upgrade-go-control-plane branch September 16, 2024 22:11
sam-heilbron added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants