Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "mod: upgrade envoyproxy/go-control-plane (#10049)" #10057

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

sam-heilbron
Copy link
Contributor

@sam-heilbron sam-heilbron commented Sep 17, 2024

Description

This reverts commit bddae6d.

Context

When pulling this into solo-projects (https://github.com/solo-io/solo-projects/pull/6909) we hit dependency issues.

Slack context with decision: https://solo-io-corp.slack.com/archives/G01EERAK3KJ/p1726605566939209

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Sep 17, 2024
@sam-heilbron
Copy link
Contributor Author

/skip-changelog
This is a revert PR so we are removing a changelog

@sam-heilbron sam-heilbron removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Sep 17, 2024
Copy link

Visit the preview URL for this PR (updated for commit ab17aa3):

https://gloo-edge--pr10057-sh-revert-go-control-ko7i3rq4.web.app

(expires Tue, 24 Sep 2024 21:00:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

@soloio-bulldozer soloio-bulldozer bot merged commit d71b7bb into main Sep 17, 2024
20 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/revert-go-control-plane branch September 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants