Add translation metrics #9862
Closed
Add translation metrics #9862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keep pr updated
lgadban
reviewed
Aug 5, 2024
| []string{"status_syncer_name"}, | ||
| ) | ||
|
|
||
| metrics.Registry.MustRegister(translationRecorder) |
There was a problem hiding this comment.
not sure this will work; I don't think /metrics currently serves the controller-runtime metrics
|
Closing in favor of #9843 for now. We will want to eventually move away from the old histogram type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a high level summary of the changes.
This bug fixes ... \ This new feature can be used to ...
Fill out any of the following sections that are relevant and remove the others
API changes
Code changes
Foo()functionBar()functionCI changes
Docs changes
Context
Users ran into this bug doing ... \ Users needed this feature to ...
See slack conversation here
Interesting decisions
We chose to do things this way because ...
Testing steps
I manually verified behavior by ...
Notes for reviewers
Be sure to verify intended behavior by ...
Please proofread comments on ...
This is a complex PR and may require a huddle to discuss ...
Checklist: