-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation metrics #9862
Closed
Closed
Add translation metrics #9862
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| package utils | ||
| package statsutils | ||
|
|
||
| import ( | ||
| "context" | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package statsutils | ||
|
|
||
| import ( | ||
| "context" | ||
| "time" | ||
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/solo-io/go-utils/contextutils" | ||
| ) | ||
|
|
||
| type StopWatch interface { | ||
| Start(ctx context.Context) | ||
| Stop(ctx context.Context) | ||
| } | ||
|
|
||
| type stopwatch struct { | ||
| hist prometheus.Observer | ||
| inProgress prometheus.Gauge | ||
| currentTime *time.Time | ||
| } | ||
|
|
||
| func NewStopWatch(hist prometheus.Observer) StopWatch { | ||
| return &stopwatch{hist: hist} | ||
| } | ||
|
|
||
| // Start begins the counter for the recorded value. | ||
| func (s *stopwatch) Start(ctx context.Context) { | ||
| if s.currentTime != nil { | ||
| contextutils.LoggerFrom(ctx).DPanic("Start() should not be called twice without calling Stop()") | ||
| return | ||
| } | ||
| now := time.Now() | ||
| s.currentTime = &now | ||
| if s.inProgress != nil { | ||
| s.inProgress.Inc() | ||
| } | ||
| } | ||
|
|
||
| // Stop ends the counter for the recorded value. This method should be called directly after | ||
| // Start(), in a defer statement. | ||
| func (s *stopwatch) Stop(ctx context.Context) { | ||
| if s.currentTime == nil { | ||
| contextutils.LoggerFrom(ctx).DPanic("Stop() should only be called after Start()") | ||
| return | ||
| } | ||
| s.hist.Observe(time.Since(*s.currentTime).Seconds()) | ||
| s.currentTime = nil | ||
| if s.inProgress != nil { | ||
| s.inProgress.Dec() | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| package statsutils | ||
|
|
||
| import ( | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "sigs.k8s.io/controller-runtime/pkg/metrics" | ||
| ) | ||
|
|
||
| var ( | ||
| translationRecorder *prometheus.HistogramVec | ||
| statusSyncerRecorder *prometheus.HistogramVec | ||
| ) | ||
|
|
||
| func init() { | ||
| translationRecorder = prometheus.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Name: "translation_time_sec", | ||
| Namespace: "gloo_edge", | ||
| Help: "how long the translator takes in seconds", | ||
| Buckets: []float64{0.25, 0.5, 0.75, 1, 2.5, 5, 10, 20, 30, 60}, | ||
| }, | ||
| []string{"translator_name"}, | ||
| ) | ||
|
|
||
| statusSyncerRecorder = prometheus.NewHistogramVec( | ||
| prometheus.HistogramOpts{ | ||
| Name: "status_syncer_time_sec", | ||
| Namespace: "gloo_edge", | ||
| Help: "how long the status syncer takes in seconds", | ||
| Buckets: []float64{0.25, 0.5, 0.75, 1, 2.5, 5, 10, 20, 30, 60}, | ||
| }, | ||
| []string{"status_syncer_name"}, | ||
| ) | ||
|
|
||
| metrics.Registry.MustRegister(translationRecorder) | ||
| metrics.Registry.MustRegister(statusSyncerRecorder) | ||
| } | ||
|
|
||
| type StopWatchFactory interface { | ||
| // NewTranslatorStopWatch returns a stop watch for the given translator | ||
| NewTranslatorStopWatch(translatorName string) StopWatch | ||
|
|
||
| // NewStatusSyncerStopWatch returns a stop watch for the given status syncer | ||
| NewStatusSyncerStopWatch(statusSyncerName string) StopWatch | ||
| } | ||
|
|
||
| func NewStatusSyncerStopWatch(statusSyncerName string) StopWatch { | ||
| return &stopwatch{ | ||
| hist: statusSyncerRecorder.WithLabelValues(statusSyncerName), | ||
| } | ||
| } | ||
|
|
||
| func NewTranslatorStopWatch(translatorName string) StopWatch { | ||
| return &stopwatch{ | ||
| hist: translationRecorder.WithLabelValues(translatorName), | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure this will work; I don't think /metrics currently serves the controller-runtime metrics