Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vigneshka/minters 2 1 #290

Merged
merged 12 commits into from
Jul 3, 2023
Merged

Vigneshka/minters 2 1 #290

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9089a93
Add platformPerTxFlatFee
Vectorized Jun 26, 2023
a54abae
Rename files and add tests
Vectorized Jun 26, 2023
96d7337
Rename platformFlatFee -> platformFlatFeeTotal
Vectorized Jun 26, 2023
f5eb23f
Add platform fee info to mint info struct
Vectorized Jun 29, 2023
9e623a8
Add SAMV1_1
Vectorized Jun 30, 2023
0529364
Add missing platformPerTxFlatFee to ISAMV1_1
Vectorized Jun 30, 2023
972c49d
generate sam id
vigneshka Jul 1, 2023
a925a4c
changeset
vigneshka Jul 1, 2023
c2b1d71
remove recursive publish
PabloSzx Jul 1, 2023
9e55879
temp
vigneshka Jul 2, 2023
568644a
Refactor totalPrice to totalPriceAndFees
Vectorized Jul 3, 2023
71d1f1c
Add test to ensure no overflow
Vectorized Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing platformPerTxFlatFee to ISAMV1_1
  • Loading branch information
@Vectorized @vigneshka
Vectorized authored and vigneshka committed Jul 1, 2023
commit 05293641a8338a07578b71a42df4f629497bbe9b
6 changes: 6 additions & 0 deletions contracts/modules/interfaces/ISAMV1_1.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,12 @@ interface ISAMV1_1 is IERC165 {
*/
function platformFeeBPS() external returns (uint16);

/**
* @dev Returns the platform per-transaction flat fee.
* @return The configured value.
*/
function platformPerTxFlatFee() external returns (uint96);

/**
* @dev Returns the platform fee address.
* @return The configured value.
Expand Down