Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vigneshka/minters 2 1 #290

Merged
merged 12 commits into from
Jul 3, 2023
Merged

Vigneshka/minters 2 1 #290

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
9089a93
Add platformPerTxFlatFee
Vectorized Jun 26, 2023
a54abae
Rename files and add tests
Vectorized Jun 26, 2023
96d7337
Rename platformFlatFee -> platformFlatFeeTotal
Vectorized Jun 26, 2023
f5eb23f
Add platform fee info to mint info struct
Vectorized Jun 29, 2023
9e623a8
Add SAMV1_1
Vectorized Jun 30, 2023
0529364
Add missing platformPerTxFlatFee to ISAMV1_1
Vectorized Jun 30, 2023
972c49d
generate sam id
vigneshka Jul 1, 2023
a925a4c
changeset
vigneshka Jul 1, 2023
c2b1d71
remove recursive publish
PabloSzx Jul 1, 2023
9e55879
temp
vigneshka Jul 2, 2023
568644a
Refactor totalPrice to totalPriceAndFees
Vectorized Jul 3, 2023
71d1f1c
Add test to ensure no overflow
Vectorized Jul 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename files and add tests
  • Loading branch information
@Vectorized @vigneshka
Vectorized authored and vigneshka committed Jul 1, 2023
commit a54abae9578a2134b9c7372fa63854f3829f628a
27 changes: 0 additions & 27 deletions contracts/core/interfaces/IMinterModuleV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,12 +128,6 @@ interface IMinterModuleV2 is IERC165 {
*/
event PlatformFlatFeeSet(uint96 flatFee);

/**
* @dev Emitted when the `platformPerTxFlatFee` is updated.
* @param perTxFlatFee The amount of platform flat fee per transaction.
*/
event PlatformPerTxFlatFeeSet(uint96 perTxFlatFee);

/**
* @dev Emitted when the `platformFeeAddress` is updated.
* @param addr The platform fee address.
Expand Down Expand Up @@ -210,11 +204,6 @@ interface IMinterModuleV2 is IERC165 {
*/
error InvalidPlatformFlatFee();

/**
* @dev The platform per-transaction flat fee must not exceed `MAX_PLATFORM_PER_TX_FLAT_FEE`.
*/
error InvalidPlatformPerTxFlatFee();

/**
* @dev The platform fee address cannot be zero.
*/
Expand Down Expand Up @@ -316,16 +305,6 @@ interface IMinterModuleV2 is IERC165 {
*/
function setPlatformFlatFee(uint96 flatFee) external;

/**
* @dev Sets the per-transaction platform flat fee.
*
* Calling conditions:
* - The caller must be the owner of the contract.
*
* @param perTxFlatFee The platform per transaction flat fee.
*/
function setPlatformPerTxFlatFee(uint96 perTxFlatFee) external;

/**
* @dev Sets the platform fee address.
*
Expand Down Expand Up @@ -374,12 +353,6 @@ interface IMinterModuleV2 is IERC165 {
*/
function MAX_PLATFORM_FLAT_FEE() external pure returns (uint96);

/**
* @dev The maximum value for platform flat fee per transaction.
* @return The constant value.
*/
function MAX_PLATFORM_PER_TX_FLAT_FEE() external pure returns (uint96);

/**
* @dev The total fees accrued for `affiliate`.
* @param affiliate The affiliate's address.
Expand Down
Loading