-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: How Not to Break a Search Engine #3446
Conversation
…morous Engineering
Notifying subscribers in CODENOTIFY files for diff a0450ea...ad38c4b.
|
I see you @bobheadxi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rvantonder 👏 This is looking great. I've left some comments to explain some of my changes, I will resolve any that don't have action items for you – these are mostly FYIs.
I like the additional subheads you've brought in towards the end. I'm not sure we have the flow of the last section right (it feels like you jump around a bit between musing about unglamorous engineering and still talking about the Sourcegraph work), but it would be great to get feedback from the others you've tagged here on that too.
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Outdated
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Outdated
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary thoughts: this resonates 🔔
And, I get the feeling that it will with a lot of other engineers too. There is a constant pull between visible, glamorous work, and the work that you know needs done, but won't be seen or appreciated. And even when it is seen and appreciated, it's not as much fun, or it's more difficult to be proud of. I love the way this post highlights that
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Outdated
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
...sts/2021/how-to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
Show resolved
Hide resolved
af6116e
to
a039a3c
Compare
or: What I Learned About Unglamorous Engineering.