Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: How Not to Break a Search Engine #3446

Merged
merged 10 commits into from
Jun 25, 2021
Merged

blog: How Not to Break a Search Engine #3446

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
da73e43
blog: How Not to Break a Search Engine or: What I Learned About Ungla…
rvantonder Jun 24, 2021
8f0fb81
Add description, hero image, copy edits
rebeccadee Jun 24, 2021
2f8e01d
feedback
rvantonder Jun 24, 2021
a039a3c
tagline
rvantonder Jun 24, 2021
afecb94
Tweak description, copy edits
rebeccadee Jun 25, 2021
4d110b5
Remove fig, make small
rebeccadee Jun 25, 2021
49ea9cc
no box shadow
rvantonder Jun 25, 2021
8d20c07
max-width:100% diagram for small width screens
rvantonder Jun 25, 2021
43a3b82
ok but like actually remove the shadow
rvantonder Jun 25, 2021
ad38c4b
Missing comma
rebeccadee Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ok but like actually remove the shadow
  • Loading branch information
@rvantonder
rvantonder committed Jun 25, 2021
commit 43a3b821c22652b5f667ae9c2ff0c1d65a25a2d3
4 changes: 2 additions & 2 deletions ...to-not-break-a-search-engine-or-what-i-learned-about-unglamorous-engineering.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ important because the parser produced a new and different internal
representation. I'd abstracted out a common interface for our backend to access
the new data structure under the feature-flagged code path to test on.

<figure style="width: 800px; max-width: 100%; margin: auto; box-shadow: none;">
<img src="https://storage.googleapis.com/sourcegraph-assets/about.sourcegraph.com/blog/2021/integration.png" alt="Integration testing diagram">
<figure style="width: 800px; max-width: 100%; margin: auto;">
<img src="https://storage.googleapis.com/sourcegraph-assets/about.sourcegraph.com/blog/2021/integration.png" alt="Integration testing diagram" style="box-shadow: none;">
<i><small>Integration testing abstracts a common interface for our backend
to access query values.
We test that the backend produces the same search results for
Expand Down