remove unused code insights JSON Schema settings #50581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code insights is no longer enabled/disabled with the `experimentalFeatures` object in user settings. That was a legacy from when it was an experimental feature.
sqs
force-pushed
the
sqs/rm-unused-insights-settings
branch
from
abedaec
to
1b32b82
Compare
Bundle size report 📦
Look at the Statoscope report for a full comparison between the commits 1b32b82 and 7161602 or learn more. Open explanation
|
burmudar
approved these changes
Apr 14, 2023
cesrjimenez
pushed a commit
that referenced
this pull request
Apr 14, 2023
- remove old isCodeInsightsEnabled guard that checked experimentalFeatures: Code insights is no longer enabled/disabled with the `experimentalFeatures` object in user settings. That was a legacy from when it was an experimental feature. - rm other unused code insights settings JSON Schema types ## Test plan Automated tests will cover it. These were not being referenced anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimentalFeaturesobject in user settings. That was a legacy from when it was an experimental feature.Test plan
Automated tests will cover it. These were not being referenced anywhere.