Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused code insights JSON Schema settings #50581

Merged
merged 2 commits into from
Apr 14, 2023
Merged

remove unused code insights JSON Schema settings #50581

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
771466d
remove old isCodeInsightsEnabled guard that checked experimentalFeatures
sqs Apr 13, 2023
1b32b82
rm other unused code insights settings JSON Schema types
sqs Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
rm other unused code insights settings JSON Schema types
  • Loading branch information
@sqs
sqs committed Apr 13, 2023
commit 1b32b82db7320ab2e0328ad96603fb25bd364634
1 change: 0 additions & 1 deletion client/web/BUILD.bazel
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

62 changes: 1 addition & 61 deletions schema/schema.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

161 changes: 0 additions & 161 deletions schema/settings.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,6 @@
"type": "object",
"additionalProperties": true,
"properties": {
"codeInsightsLandingPage": {
"deprecated": true,
"description": "DEPRECATED: Enables code insights landing page layout.",
"type": "boolean",
"default": false,
"!go": {
"pointer": true
}
},
"codeInsightsRepoUI": {
"description": "Specifies which (code insight repo) editor to use for repo query UI",
"type": "string",
Expand Down Expand Up @@ -518,27 +509,6 @@
"pointer": true
}
},
"insights.displayLocation.insightsPage": {
"type": "boolean",
"default": true,
"!go": {
"pointer": true
}
},
"insights.displayLocation.directory": {
"type": "boolean",
"default": true,
"!go": {
"pointer": true
}
},
"insights.displayLocation.homepage": {
"type": "boolean",
"default": true,
"!go": {
"pointer": true
}
},
"insights.aggregations.extendedTimeout": {
"description": "The number of seconds to execute the aggregation for when running in extended timeout mode. This value should always be less than any proxy timeout if one exists. The maximum value is equal to searchLimits.maxTimeoutSeconds",
"type": "integer",
Expand All @@ -555,137 +525,6 @@
}
},
"definitions": {
"BackendInsight": {
"type": "object",
"required": ["title", "series"],
"properties": {
"title": {
"type": "string",
"description": "The short title of this insight"
},
"description": {
"type": "string",
"description": "The description of this insight"
},
"series": {
"type": "array",
"description": "Each query will be represented by one line on the chart.",
"items": {
"$ref": "#/definitions/BackendInsightSeries"
}
},
"filters": {
"$ref": "#/definitions/InsightFilters"
}
}
},
"BackendInsightSeries": {
"type": "object",
"additionalProperties": false,
"required": ["name", "query"],
"properties": {
"name": {
"type": "string",
"description": "The name to use for the series in the graph."
},
"query": {
"type": "string",
"description": "Performs a search query and shows the number of results returned."
},
"stroke": {
"type": "string",
"description": "The color of the line for the series."
}
}
},
"InsightFilters": {
"type": "object",
"description": "Performs a filter",
"required": ["includeRepoRegexp", "excludeRepoRegexp"],
"properties": {
"includeRepoRegexp": {
"type": "string"
},
"excludeRepoRegexp": {
"type": "string"
},
"repositories": {
"type": "array",
"items": {
"type": "string"
}
}
}
},
"InsightDashboard": {
"type": "object",
"required": ["id", "title"],
"properties": {
"title": {
"description": "Title of the dashboard.",
"type": "string"
},
"id": {
"type": "string"
},
"insightIds": {
"description": "Insights ids that will be included in the dashboard.",
"type": "array",
"items": {
"type": "string"
}
}
}
},
"Insight": {
"type": "object",
"additionalProperties": false,
"required": ["title", "description", "series", "id"],
"properties": {
"title": {
"type": "string",
"description": "The short title of this insight"
},
"description": {
"type": "string",
"description": "The description of this insight"
},
"series": {
"type": "array",
"description": "Series of data to show for this insight",
"items": {
"$ref": "#/definitions/InsightSeries"
}
},
"id": {
"type": "string",
"description": "A globally unique identifier for this insight."
}
}
},
"InsightSeries": {
"type": "object",
"additionalProperties": false,
"required": ["label"],
"properties": {
"label": {
"type": "string",
"description": "The label to use for the series in the graph."
},
"repositoriesList": {
"type": "array",
"description": "Performs a search query and shows the number of results returned."
},
"search": {
"type": "string",
"description": "Performs a search query and shows the number of results returned."
},
"webhook": {
"type": "string",
"description": "(not yet supported) Fetch data from a webhook URL."
}
}
},
"SearchScope": {
"type": "object",
"additionalProperties": false,
Expand Down