Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Init userpasswd provider where we initialize every other authn provider #64061

Conversation

eseliger
Copy link
Member

Just a little cleanup which makes the main function a bit shorter and easier to understand that userpasswd is not different to other authn providers.

Test plan: Authn with builtin still works in CI integration tests.

Copy link
Member Author

eseliger commented Jul 25, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 4eba238 to 4eb55b6 Compare July 29, 2024 23:13
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from ead8701 to a5655e4 Compare July 29, 2024 23:35
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 4eb55b6 to 7865ff1 Compare July 29, 2024 23:36
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from a5655e4 to bc77455 Compare July 30, 2024 00:47
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 7865ff1 to 14845f5 Compare July 30, 2024 00:48
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from bc77455 to 5fb3e86 Compare July 30, 2024 17:22
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 14845f5 to 1f5cf02 Compare July 30, 2024 17:22
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from 5fb3e86 to 3863570 Compare July 30, 2024 23:29
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 1f5cf02 to 1a7b2e4 Compare July 30, 2024 23:30
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from 3863570 to edcb05b Compare July 31, 2024 01:05
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 1a7b2e4 to 6f191d6 Compare July 31, 2024 01:06
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from edcb05b to cc245dd Compare July 31, 2024 01:20
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 6f191d6 to 9d0d757 Compare July 31, 2024 01:21
@eseliger eseliger force-pushed the es/07-25-choreremoveglobalexternalurlwatcher branch from cc245dd to 2193422 Compare July 31, 2024 01:37
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from 9d0d757 to c882243 Compare July 31, 2024 01:38
Base automatically changed from es/07-25-choreremoveglobalexternalurlwatcher to main July 31, 2024 01:43
… provider

Just a little cleanup which makes the main function a bit shorter and easier to understand that userpasswd is not different to other authn providers.

Test plan: Authn with builtin still works in CI integration tests.
@eseliger eseliger force-pushed the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch from c882243 to 76e7780 Compare July 31, 2024 01:44
@eseliger eseliger merged commit 03c2907 into main Jul 31, 2024
14 checks passed
@eseliger eseliger deleted the es/07-25-choreinituserpasswdproviderwhereweinitializeeveryotherauthnprovider branch July 31, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants