chore: move internal/suspiciousnames to cmd/frontend/internal #64071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2024
github-actions
bot
added
team/product-platform
team/source
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
8f52067
to
8130ebc
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
7e3bcff
to
419bb0d
Compare
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
8130ebc
to
09aa64a
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
419bb0d
to
6344e51
Compare
pjlast
approved these changes
Jul 30, 2024
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
8dc6d74
to
294ed57
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
fd96703
to
94bc2eb
Compare
This was referenced Jul 30, 2024
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
294ed57
to
5d84bc8
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
94bc2eb
to
1ee0818
Compare
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
5d84bc8
to
b0f7915
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
1ee0818
to
6544b5e
Compare
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
b0f7915
to
ab53645
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
6544b5e
to
d25b98a
Compare
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
ab53645
to
4e53a43
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
d25b98a
to
f853edc
Compare
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
4e53a43
to
184f24a
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
f853edc
to
e680c47
Compare
…lickexport This package is only used inside frontend, so no need to expose it publicly. Test plan: Just moved one folder, Go compiler doesn't complain.
This package is no longer required now that everything that depends on session is inside cmd/frontend. This removes one layer of indirection in the code nav flow. Test plan: Just removed aliases and pointed to the original code, and the Go compiler doesn't complain.
Just another package that is now only used by frontend, so moving it around to make clearer which service needs this package. Test plan: Go compiler doesn't complain about moved directory.
eseliger
force-pushed
the
es/07-25-choreremovecmdfrontendexternalredirectionpackage
branch
from
184f24a
to
283961d
Compare
eseliger
force-pushed
the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
from
e680c47
to
43783c6
Compare
Base automatically changed from
es/07-25-choreremovecmdfrontendexternalredirectionpackage
to
main
July 31, 2024 02:42
eseliger
deleted the
es/07-25-choremoveinternalsuspiciousnamestocmdfrontendinternal
branch
This was referenced Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just another package that is now only used by frontend, so moving it around to make clearer which service needs this package.
Test plan: Go compiler doesn't complain about moved directory.