Fix action bar design #9503
Merged
Fix action bar design #9503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfbecker
added
webapp
extensions
Links need empty href to be styled properly. Rewrite component to function component.
felixfbecker
force-pushed
the
fix-action-bar-design
branch
from
bd21c0c
to
b6697bf
Compare
Codecov Report
@@ Coverage Diff @@
## master #9503 +/- ##
=======================================
Coverage 41.53% 41.53%
=======================================
Files 1332 1332
Lines 72585 72584 -1
Branches 6582 6578 -4
=======================================
Hits 30145 30145
+ Misses 39641 39640 -1
Partials 2799 2799
|
eseliger
approved these changes
Apr 2, 2020
felixfbecker
force-pushed
the
fix-action-bar-design
branch
from
9697056
to
3e7c5bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9462
We set a custom padding that made the buttons hard to distinguish, assymmetric and inconsistent with the rest of the UI. I simply removed the custom padding so it's consistent with all other buttons. We definitely have the space to do that.
I added a 1px gap between buttons so that they are distinct even in "pressed" state. Not fully sure about this one but I settled on it looking better than without.
I also fixed a tiny 1px gap at the bottom of each item by making them stretch.
This also fixes the font color differences between buttons that did not have an
href, and the different cursor. In the process I converted the component to a function component.Action items that are too wide are now clipped with ellipsis.
I modified the "pressed" background color to be a tad lighter. The problem before was that it was the same color as the frame of the action bar, so they didn't appear "pressed", but actually a layer above the bar. With this slight modification I find the state is much better communicated.
On hover action items receive a background lighter than the pressed state. This made a huge difference imo in making them feel like interactive UI elements.
Please note that the gifs are not fully representative because the color resolution is small.