Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix action bar design #9503

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Fix action bar design #9503

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4454f4
Fix action item padding
felixfbecker Apr 2, 2020
06c4064
Fix style of action item that is not a link
felixfbecker Apr 2, 2020
11f0304
Clip too wide action items
felixfbecker Apr 2, 2020
b6697bf
Fix spacing between icon and label
felixfbecker Apr 2, 2020
3e7c5bd
Add hover background effect
felixfbecker Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add hover background effect
  • Loading branch information
@felixfbecker
felixfbecker committed Apr 2, 2020
commit 3e7c5bd0aaab12cafade5eac314179aeec0e399f
37 changes: 24 additions & 13 deletions web/src/repo/RepoHeader.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,19 @@
.nav-item {
display: flex;
align-items: center;
margin-left: 0.125rem;

// Have a small gap between buttons so they are visually distinct when pressed
// stylelint-disable-next-line declaration-property-unit-whitelist
margin-left: 1px;

&:hover {
.theme-dark & {
background: $color-bg-1;
}
.theme-light & {
background: $color-light-bg-2;
}
}

.nav-link {
user-select: none;
Expand Down Expand Up @@ -52,24 +64,23 @@
&__spacer {
flex: 1 1 0;
}
}

.theme-dark {
.repo-header {
.theme-dark & {
border-color: #233043;
}
.action-item--pressed {
background-color: $color-bg-3;
color: $color-text-3;
}
}

.theme-light {
.repo-header {
.theme-light & {
border-color: $color-light-border;
}

.action-item--pressed {
background-color: $color-light-bg-3;
color: $color-light-text-1;
.theme-dark & {
background-color: $color-bg-2;
color: $color-text-3;
}
.theme-light & {
background-color: $color-light-bg-4;
color: $color-light-text-1;
}
}
}