remove normal priority argument in new interface init threadpool so 2…

…020_U3 can use the new interface
stan-dev · rok-cesnovar · Mar 26, 2021 · Mar 23, 2021 · Mar 23, 2021 · Mar 23, 2021
commit 420b2eafdee92902230d5f688c60c67700527583
diff --git a/lib/tbb_2020.3/STAN_CHANGES b/lib/tbb_2020.3/STAN_CHANGES
@@ -0,0 +1,3 @@
+This file documents changes done for the stan-math project
+
+- drop -g flag from makefiles for release mode builds to decrease size of binaries
diff --git a/lib/tbb_2020.3/build/BSD.clang.inc b/lib/tbb_2020.3/build/BSD.clang.inc
@@ -35,7 +35,7 @@ LINK_FLAGS = -Wl,-rpath-link=. -Wl,-rpath=. -rdynamic
 C_FLAGS = $(CPLUS_FLAGS)
 
 ifeq ($(cfg), release)
-        CPLUS_FLAGS = $(ITT_NOTIFY) -g -O2 -DUSE_PTHREAD
+        CPLUS_FLAGS = $(ITT_NOTIFY) -O2 -DUSE_PTHREAD
 endif
 ifeq ($(cfg), debug)
         CPLUS_FLAGS = -DTBB_USE_DEBUG $(ITT_NOTIFY) -g -O0 -DUSE_PTHREAD

diff --git a/lib/tbb_2020.3/build/FreeBSD.gcc.inc b/lib/tbb_2020.3/build/FreeBSD.gcc.inc
@@ -38,7 +38,7 @@ ifneq (,$(shell gcc -dumpfullversion -dumpversion | egrep  "^([6-9]|1[0-9])"))
 endif
 
 ifeq ($(cfg), release)
-        CPLUS_FLAGS = -g -O2 -DUSE_PTHREAD
+        CPLUS_FLAGS = -O2 -DUSE_PTHREAD
 endif
 ifeq ($(cfg), debug)
         CPLUS_FLAGS = -DTBB_USE_DEBUG -g -O0 -DUSE_PTHREAD

diff --git a/lib/tbb_2020.3/build/SunOS.gcc.inc b/lib/tbb_2020.3/build/SunOS.gcc.inc
@@ -33,7 +33,7 @@ LIBS = -lpthread -lrt -ldl
 C_FLAGS = $(CPLUS_FLAGS) -x c
 
 ifeq ($(cfg), release)
-        CPLUS_FLAGS = -g -O2 -DUSE_PTHREAD
+        CPLUS_FLAGS = -O2 -DUSE_PTHREAD
 endif
 ifeq ($(cfg), debug)
         CPLUS_FLAGS = -DTBB_USE_DEBUG -g -O0 -DUSE_PTHREAD

diff --git a/lib/tbb_2020.3/build/linux.clang.inc b/lib/tbb_2020.3/build/linux.clang.inc
@@ -36,7 +36,7 @@ C_FLAGS = $(CPLUS_FLAGS)
 
 ifeq ($(cfg), release)
         # -g is set intentionally in the release mode. It should not affect performance.
-        CPLUS_FLAGS = -O2 -g
+        CPLUS_FLAGS = -O2
 endif
 ifeq ($(cfg), debug)
         CPLUS_FLAGS = -DTBB_USE_DEBUG -O0 -g

diff --git a/lib/tbb_2020.3/build/linux.icc.inc b/lib/tbb_2020.3/build/linux.icc.inc
@@ -35,7 +35,7 @@ ITT_NOTIFY = -DDO_ITT_NOTIFY
 ifeq (release,$(cfg))
 SDL_FLAGS += -D_FORTIFY_SOURCE=2
 # -g is set intentionally in the release mode. It should not affect performance.
-CPLUS_FLAGS = -O2 -g -qno-opt-report-embed
+CPLUS_FLAGS = -O2 -qno-opt-report-embed
 else
 CPLUS_FLAGS = -O0 -g -DTBB_USE_DEBUG
 endif
@@ -116,4 +116,3 @@ M_CPLUS_FLAGS = $(CPLUS_FLAGS) -fno-rtti -fno-exceptions
 #------------------------------------------------------------------------------
 # End of setting tbbmalloc data.
 #------------------------------------------------------------------------------
-
diff --git a/lib/tbb_2020.3/build/linux.pathcc.inc b/lib/tbb_2020.3/build/linux.pathcc.inc
@@ -38,7 +38,7 @@ C_FLAGS = $(CPLUS_FLAGS)
 OPENMP_FLAG = -openmp
 
 ifeq ($(cfg), release)
-        CPLUS_FLAGS = $(ITT_NOTIFY) -g -O2 -DUSE_PTHREAD
+        CPLUS_FLAGS = $(ITT_NOTIFY) -O2 -DUSE_PTHREAD
 endif
 ifeq ($(cfg), debug)
         CPLUS_FLAGS = -DTBB_USE_DEBUG $(ITT_NOTIFY) -g -O0 -DUSE_PTHREAD

diff --git a/lib/tbb_2020.3/build/macos.clang.inc b/lib/tbb_2020.3/build/macos.clang.inc
@@ -35,7 +35,7 @@ LIB_LINK_FLAGS = -dynamiclib -install_name @rpath/$(BUILDING_LIBRARY)
 C_FLAGS = $(CPLUS_FLAGS)
 
 ifeq ($(cfg), release)
-    CPLUS_FLAGS = -g -O2
+    CPLUS_FLAGS = -O2
 else
     CPLUS_FLAGS = -g -O0 -DTBB_USE_DEBUG
 endif

diff --git a/lib/tbb_2020.3/build/macos.gcc.inc b/lib/tbb_2020.3/build/macos.gcc.inc
@@ -53,7 +53,7 @@ ifneq (,$(shell $(CONLY) -dumpfullversion -dumpversion | egrep  "^([6-9]|1[0-9])
 endif
 
 ifeq ($(cfg), release)
-    CPLUS_FLAGS = -g -O2
+    CPLUS_FLAGS = -O2
 else
     CPLUS_FLAGS = -g -O0 -DTBB_USE_DEBUG
 endif

diff --git a/lib/tbb_2020.3/build/macos.icc.inc b/lib/tbb_2020.3/build/macos.icc.inc
@@ -49,7 +49,7 @@ endif
 
 ifeq ($(cfg), release)
     SDL_FLAGS += -D_FORTIFY_SOURCE=2
-    CPLUS_FLAGS = -g -O2 -fno-omit-frame-pointer -qno-opt-report-embed
+    CPLUS_FLAGS = -O2 -fno-omit-frame-pointer -qno-opt-report-embed
 else
     CPLUS_FLAGS = -g -O0 -DTBB_USE_DEBUG
 endif

diff --git a/lib/tbb_2020.3/build/mic.icc.inc b/lib/tbb_2020.3/build/mic.icc.inc
@@ -31,7 +31,7 @@ SDL_FLAGS = -fstack-protector -Wformat -Wformat-security
 
 ifeq (release,$(cfg))
     SDL_FLAGS += -D_FORTIFY_SOURCE=2
-    CPLUS_FLAGS = -O2 -g -DUSE_PTHREAD
+    CPLUS_FLAGS = -O2 -DUSE_PTHREAD
 else
     CPLUS_FLAGS = -O0 -g -DUSE_PTHREAD -DTBB_USE_DEBUG
 endif
@@ -70,6 +70,3 @@ M_CPLUS_FLAGS = $(CPLUS_FLAGS) -fno-rtti -fno-exceptions
 #------------------------------------------------------------------------------
 # End of setting tbbmalloc data.
 #------------------------------------------------------------------------------
-
-
-
diff --git a/lib/tbb_2020.3/build/windows.gcc.inc b/lib/tbb_2020.3/build/windows.gcc.inc
@@ -85,7 +85,7 @@ ifeq (ok,$(call detect_js,/minversion gcc 6.0))
 endif
 
 ifeq ($(cfg), release)
-        CPLUS_FLAGS = -g -O2
+        CPLUS_FLAGS = -O2
 endif
 ifeq ($(cfg), debug)
         CPLUS_FLAGS = -g -O0 -DTBB_USE_DEBUG

diff --git a/stan/math/prim/core/init_threadpool_tbb.hpp b/stan/math/prim/core/init_threadpool_tbb.hpp
@@ -90,8 +90,7 @@ inline tbb::task_arena& init_threadpool_tbb() {
   static tbb::global_control tbb_gc(
       tbb::global_control::max_allowed_parallelism, tbb_max_threads);
 
-  static tbb::task_arena tbb_arena(tbb_max_threads, 1,
-                                   tbb::task_arena::priority::normal);
+  static tbb::task_arena tbb_arena(tbb_max_threads, 1);
   tbb_arena.initialize();
 
   return tbb_arena;