-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disabling Hermes engine by passing flag while building app #14041
Conversation
Jenkins BuildsClick to see older builds (14)
|
466f22f
to
5fc6a5a
Compare
5fc6a5a
to
eafe749
Compare
eafe749
to
c7e6715
Compare
3% of end-end tests have passed
Failed tests (84)Click to expandClass TestPublicChatBrowserOneDeviceMerged:
Class TestPairingSyncMultipleDevicesMerged:
Class TestOnboardingOneDeviceMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestSendTxDeviceMerged:
Class TestKeycardTxOneDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestPublicChatMultipleDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestRestoreOneDeviceMerged:
Passed tests (3)Click to expandSingle device tests:
|
498f25c
to
a04738c
Compare
99% of end-end tests have passed
Failed tests (1)Click to expandClass TestKeycardTxOneDeviceMerged:
Passed tests (86)Click to expandClass TestSendTxDeviceMerged:
Class TestWalletManagementDeviceMerged:
Class TestCommandsMultipleDevicesMerged:
Class TestGroupChatMultipleDeviceMerged:
Class TestOnboardingOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevices:
Class TestPairingSyncMultipleDevicesMerged:
Class TestRestoreOneDeviceMerged:
Class TestPublicChatMultipleDeviceMerged:
Class TestContactBlockMigrateKeycardMultipleSharedDevices:
Class TestPublicChatBrowserOneDeviceMerged:
Class TestEnsStickersMultipleDevicesMerged:
Class TestKeycardTxOneDeviceMerged:
|
fixes: #14031
Summary
Hermes is introduced in #8943 PR for performance improvements and also to fix app freezes in arm64 android devices.
For arm64 devices it is working great, but for x86 devices it is crashing debug app after reloading it a few times. It is a probably library bug, but we can't upgrade to newer versions because it depends on the react-native version.
So this PR allows passing the flag
DISABLE_HERMES
for disabling Hermes while building the app for those devices.Testing
(.-HermesInternal ^js js/global)
inside Clojure code. It returnsnil
when Hermes is disabled and#js {}
when enabled.PS: Beside 10 MB size difference, I didn't faced any performance issues even after disabling hermes
status: ready