Upgrade to RN 0.60.5 and enable Hermes JS engine #8943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedropombeiro
requested review from
jakubgs,
oskarth and
a team
as code owners
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (58)
|
pedropombeiro
changed the title
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
c45e145
to
9242a9d
Compare
1 similar comment
Closed
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
9242a9d
to
ab5b950
Compare
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
ab5b950
to
4535152
Compare
yenda
force-pushed
the
remove-realm-final
branch
from
222c73a
to
7201dcb
Compare
yenda
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
4535152
to
598a692
Compare
|
@Serhy will investigate the perf issue separately |
|
Can exchange messages in 1-1/Public/Group chat (custom userpic shared too) I don't see regressions apart performance one which will be looked at separately |
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
22d2213
to
d7d1d93
Compare
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
d7d1d93
to
5401d24
Compare
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
5401d24
to
bfabd91
Compare
Merged
added 3 commits
September 12, 2019 16:13
- Use community net-info, react-native-webview instead of deprecated react-native classes - Remove react-native-tcp - Upgrade react-native libs (react-native-camera, react-native-firebase, react-native-mail, react-native-udp, react-native-webview-bridge) - Do not include `:react-native-android` module explicitly - Take advantage of RN AutoLinking - nix: Update Gradle dependencies
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
bfabd91
to
e07ca28
Compare
Signed-off-by: Pedro Pombeiro <pombeirp@users.noreply.github.com>
pedropombeiro
force-pushed
the
feature/upgrade-to-rn-hermes
branch
from
e07ca28
to
cc79cf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8672
fixes #8665
Summary
This PR fixes the 64-bit issue on Android by enabling Hermes on RN 0.60.5. It has quite a few considerations, since some deprecated components were removed from RN and moved into separate community projects, sometimes with changed APIs (e.g. react-native-camera, react-native-webview).
Review notes
This PR is based on the branch from #8932 in order to minimize future merges.
It takes advantage of the new AutoLinking functionality in Realm, so a lot of cruft was removed from gradle and pod files.
A gist of the changes in this PR:
gradle react-native-android:installArchivesno longer exists (the archives are downloaded directly) so had to remove that from the Nix expressioncallRPCtoWebViewBridgePackageTesting notes
Full regression testing (special focus on web browser-related functionality on iOS)
Platforms
Areas that maybe impacted
Non-functional
status: ready