-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LFRic] Support for user-defined kernels that operate on DoFs #1351
Comments
Following on from our chat in the telco this morning, it sounds as though the random-number initialisation functionality needed for PSyAD should also be a dof-wise kernel. In fact, for the simplest case it could just be a built-in? I guess it depends on what Ben's existing kernel code already does? |
Proposed changes:Allowed metadata types and access
LFRic Builtins metadata vs User defined kernels metadataLFRic builtins use the Changes
No Change
|
also added checks in LFricKernelMetadata for operates_on=dof which check if the kernel is a builtin and, if not, runs kernel checks similar to generic and domain kernels."
…FRicKernMetadata or LFRicArgDescriptor
#1351 - Support for user-defined kernels that operate on DoFs
#2556 only added the documentation, not the implementation. |
Originally we had preliminary support for user-defined kernels that operate on DoFs. However, it produced incorrect code and we removed it until the need arises.
There are several LFRic PSyKAl-lite routines that could be removed with this support, hence this issue. Furthermore, it seems that we need to differentiate between
operates_on = DOF
andoperates_on = DOF_COLUMN
.The text was updated successfully, but these errors were encountered: