-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DoF kern code generation checklist #2711
Comments
oakleybrunt
added a commit
that referenced
this issue
Sep 16, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 19, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 19, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 19, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 19, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 19, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 19, 2024
Just a note for the future: there's no need to open an Issue 'towards' another Issue :-) Just add to the existing Issue. It is then the PR that is 'towards' that existing Issue. |
Noted, thanks :) |
oakleybrunt
added a commit
that referenced
this issue
Sep 20, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 20, 2024
oakleybrunt
added a commit
that referenced
this issue
Sep 22, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 7, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 8, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 8, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 8, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 8, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 8, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 9, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 9, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 9, 2024
oakleybrunt
added a commit
that referenced
this issue
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Towards #1351
This is a checklist of features that DoF kernel code generation needs.
Loop
Question - should dof kerns have a different loopupper_bound_name
? This would distinguish them from builtin loops (maybe not wanted) but would allow for less conditional branching in the setting of upper_bound.'df'
name and'dof_loop_idx'
tag -LFRicKernCallFactory
&LFRicLoop
f1_proxy%vspace%get_ncell()
but should be theundf_name
belonging to the function space. Since there is only one FS allowed, this should work fine.Kernel call
map_FS(:,cell)
)f1_data(df)
)Declarations
Potentially remove FS name fromundf
because there should only ever be one FS for dof kerns^ Above introduces more conditionals which seem unnecessary. Most egregious is having a property of
FunctionSpace
class that returns just'undf'
and then finding all instances where'undf_name'
property is accessed and adding a conditional check for a dof kernel. Unfortunately, this seems like the only way to do it since theFunctionSpace
class does not have access to the kernel it belongs to, and therefore cannot determine if said kernel is a dof kern.The text was updated successfully, but these errors were encountered: